flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #4061: [FLINK-6841][table]Using TableSourceTable for both...
Date Sun, 11 Jun 2017 10:40:59 GMT
Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4061#discussion_r121278080
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/catalog/ExternalTableSourceUtilTest.scala
---
    @@ -42,7 +42,7 @@ class ExternalTableSourceUtilTest {
         val schema = new TableSchema(Array("foo"), Array(BasicTypeInfo.INT_TYPE_INFO))
         val table = ExternalCatalogTable("mock", schema)
         val tableSource = ExternalTableSourceUtil.fromExternalCatalogTable(table)
    -    assertTrue(tableSource.isInstanceOf[StreamTableSourceTable[_]])
    +    assertTrue(tableSource.isInstanceOf[TableSourceTable[_]])
    --- End diff --
    
    I think checking the result of `fromExternalCatalogTable` is a `TableSourceTable` is meaningless
now (it definitely returns a `TableSourceTable`).  I suggest to check whether the `TableSource`
in the `TableSourceTable` is a `StreamTableSource`.
    
    ```
    assertTrue(tableSource.tableSource.isInstanceOf[StreamTableSource[_]])
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message