flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4123: [FLINK-6498] Migrate Zookeeper configuration optio...
Date Mon, 19 Jun 2017 11:40:12 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4123#discussion_r122684018
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java
---
    @@ -391,11 +370,11 @@ public static String generateZookeeperPath(String root, String namespace)
{
     		 * Return the configured {@link ZkClientACLMode}.
     		 *
     		 * @param config The config to parse
    -		 * @return Configured ACL mode or {@link ConfigConstants#DEFAULT_HA_ZOOKEEPER_CLIENT_ACL}
if not
    +		 * @return Configured ACL mode or {@link HighAvailabilityOptions#ZOOKEEPER_CLIENT_ACL}
if not
     		 * configured.
     		 */
     		public static ZkClientACLMode fromConfig(Configuration config) {
    -			String aclMode = config.getString(ConfigConstants.HA_ZOOKEEPER_CLIENT_ACL, null);
    +			String aclMode = config.getString(HighAvailabilityOptions.ZOOKEEPER_CLIENT_ACL, null);
    --- End diff --
    
    `null` argument can be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message