flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4123: [FLINK-6498] Migrate Zookeeper configuration optio...
Date Mon, 19 Jun 2017 11:40:12 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4123#discussion_r122682661
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -922,65 +922,111 @@
     
     	// --------------------------- ZooKeeper ----------------------------------
     
    -	/** ZooKeeper servers. */
    +	/**
    +	 * ZooKeeper servers.
    +	 * @deprecated in favor of {@link HighAvailabilityOptions#HA_ZOOKEEPER_QUORUM}.
    +	 */
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_QUORUM_KEY = "high-availability.zookeeper.quorum";
     
     	/**
     	 * File system state backend base path for recoverable state handles. Recovery state
is written
     	 * to this path and the file state handles are persisted for recovery.
    +	 * @deprecated in favor of {@link HighAvailabilityOptions#HA_STORAGE_PATH}.
     	 */
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_STORAGE_PATH = "high-availability.zookeeper.storageDir";
     
    -	/** ZooKeeper root path. */
    +	/**
    +	 * ZooKeeper root path.
    +	 * @deprecated in favor of {@link HighAvailabilityOptions#HA_ZOOKEEPER_ROOT}.
    +	 */
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_DIR_KEY = "high-availability.zookeeper.path.root";
     
    +	/** @deprecated in favor of {@link HighAvailabilityOptions#HA_ZOOKEEPER_NAMESPACE}.
*/
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_NAMESPACE_KEY = "high-availability.zookeeper.path.namespace";
     
    +	/** @deprecated in favor of {@link HighAvailabilityOptions#HA_ZOOKEEPER_LATCH_PATH}.
*/
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_LATCH_PATH = "high-availability.zookeeper.path.latch";
     
    -	/** ZooKeeper root path (ZNode) for job graphs. */
    +	/**
    +	 * ZooKeeper root path (ZNode) for job graphs.
    +	 * @deprecated in favor of {@link HighAvailabilityOptions#HA_ZOOKEEPER_JOBGRAPHS_PATH}.
    +	 */
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_JOBGRAPHS_PATH = "high-availability.zookeeper.path.jobgraphs";
     
    +	/** @deprecated in favor of {@link HighAvailabilityOptions#HA_ZOOKEEPER_LEADER_PATH}.
*/
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_LEADER_PATH = "high-availability.zookeeper.path.leader";
     
    -	/** ZooKeeper root path (ZNode) for completed checkpoints. */
    +	/**
    +	 * ZooKeeper root path (ZNode) for completed checkpoints.
    +	 * @deprecated in favor of {@link HighAvailabilityOptions#HA_ZOOKEEPER_CHECKPOINTS_PATH}.
    +	 */
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_CHECKPOINTS_PATH = "high-availability.zookeeper.path.checkpoints";
     
    -	/** ZooKeeper root path (ZNode) for checkpoint counters. */
    +	/**
    +	 * ZooKeeper root path (ZNode) for checkpoint counters.
    +	 * @deprecated in favor of {@link HighAvailabilityOptions#HA_ZOOKEEPER_CHECKPOINT_COUNTER_PATH}.
    +	 */
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_CHECKPOINT_COUNTER_PATH = "high-availability.zookeeper.path.checkpoint-counter";
     
    -	/** ZooKeeper root path (ZNode) for Mesos workers. */
    +	/**
    +	 * ZooKeeper root path (ZNode) for Mesos workers.
    +	 * @deprecated in favor of {@link HighAvailabilityOptions#HA_ZOOKEEPER_MESOS_WORKERS_PATH}.
    +	 */
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_MESOS_WORKERS_PATH = "high-availability.zookeeper.path.mesos-workers";
     
    +	/** @deprecated in favor of {@link HighAvailabilityOptions#ZOOKEEPER_SESSION_TIMEOUT}.
*/
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_SESSION_TIMEOUT = "high-availability.zookeeper.client.session-timeout";
     
    +	/** @deprecated in favor of {@link HighAvailabilityOptions#ZOOKEEPER_CONNECTION_TIMEOUT}.
*/
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_CONNECTION_TIMEOUT = "high-availability.zookeeper.client.connection-timeout";
     
    +	/** @deprecated in favor of {@link HighAvailabilityOptions#ZOOKEEPER_RETRY_WAIT} */
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_RETRY_WAIT = "high-availability.zookeeper.client.retry-wait";
     
    +	/** @deprecated in favor of {@link HighAvailabilityOptions#ZOOKEEPER_MAX_RETRY_ATTEMPTS}.
*/
     	@PublicEvolving
    +	@Deprecated
     	public static final String HA_ZOOKEEPER_MAX_RETRY_ATTEMPTS = "high-availability.zookeeper.client.max-retry-attempts";
     
    +	/** @deprecated in favor of {@link HighAvailabilityOptions#HA_ZOOKEEPER_CLIENT_ACL}.
*/
    --- End diff --
    
    remove `HA_` prefix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message