flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4022: [FLINK-5488] stop YarnClient before exception is t...
Date Mon, 19 Jun 2017 12:07:01 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4022#discussion_r122688461
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientV2.java ---
    @@ -146,7 +146,9 @@ public ApplicationStatus getApplicationStatus() {
     
     	@Override
     	public void finalizeCluster() {
    -		// Do nothing
    --- End diff --
    
    Please revert the changes here. This file is part of another big initiative (referred
to as FLIP-6); we shouldn't touch it unless necessary. (basically, I don't know about the
yarn-client life-cycle here so let's be conservative.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message