flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4088: [FLINK-6652] [core] Fix handling of delimiters spl...
Date Tue, 20 Jun 2017 10:34:19 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4088#discussion_r122929197
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
    @@ -246,6 +246,9 @@ public void setDelimiter(String delimiter) {
     			throw new IllegalArgumentException("Delimiter must not be null");
     		}
     		this.delimiter = delimiter.getBytes(getCharset());
    +		if (this.bufferSize > 0 && this.delimiter.length >= this.bufferSize)
{
    --- End diff --
    
    since the initial value for `bufferSize` is `-1` doesn't this mean that the delimiter
can never be set without calling `setBufferSize`? Would it make sense to move this check into
`open()`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message