flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4088: [FLINK-6652] [core] Fix handling of delimiters spl...
Date Tue, 20 Jun 2017 10:34:19 GMT
Github user zentol commented on a diff in the pull request:

    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
    @@ -269,6 +272,9 @@ public void setBufferSize(int bufferSize) {
     		if (bufferSize < 1) {
     			throw new IllegalArgumentException("Buffer size must be at least 1.");
    +		if (bufferSize <= delimiter.length) {
    --- End diff --
    we should also adjust the condition above that `bufferSize` must be be greater than one.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message