flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...
Date Tue, 20 Jun 2017 14:19:18 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4145#discussion_r122982179
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java
---
    @@ -36,6 +36,12 @@
     	private final StateTransitionAction action;
     	private final State<T> sourceState;
     	private final State<T> targetState;
    +
    +	/**
    +	 * @deprecated 	This field remains for backwards compatibility.
    +	 * Now the condition is stored in {@link ConditionRegistry}.
    +	 */
    +	@Deprecated
     	private IterativeCondition<T> newCondition;
    --- End diff --
    
    Fields introduced prior to 1.3.0 needed to be `@deprecated` because java serialization
was used for serializing NFA. Since 1.3.0 a custom serialization is used and this field was
introduced for 1.3.0 so I think we can get rid of it completely. Am I right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message