flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjureel <...@git.apache.org>
Subject [GitHub] flink pull request #4075: [FLINK-6494] Migrate ResourceManager/Yarn/Mesos co...
Date Wed, 21 Jun 2017 08:13:04 GMT
Github user zjureel commented on a diff in the pull request:

    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
    @@ -52,7 +52,74 @@
    +	/**
    +	 * The vcores exposed by YARN.
    +	 */
    +	public static final ConfigOption<Integer> YARN_VCORES =
    +		key("yarn.containers.vcores")
    +		.defaultValue(Integer.MAX_VALUE);
    --- End diff --
    I determine this default by test case, sorry :( 
    In fact I want to use `noDefaultValue()` here, but I find this method can be used for
`String` only, and there's no `getInteger(ConfigOption<Integer> option, int overrideDefault)`
in `Configuration`.
    I think it may be better to add `public ConfigOption<T> noDefaultValue()` in `ConfigOptions`
and add `public int getString(ConfigOption<Integer> configOption, int overrideDefault)`
in `Configuration` . What do you think? THX :)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message