flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4075: [FLINK-6494] Migrate ResourceManager/Yarn/Mesos co...
Date Wed, 21 Jun 2017 09:26:24 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4075#discussion_r123197240
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
---
    @@ -52,7 +52,74 @@
     		key("yarn.per-job-cluster.include-user-jar")
     			.defaultValue("ORDER");
     
    +	/**
    +	 * The vcores exposed by YARN.
    +	 */
    +	public static final ConfigOption<Integer> YARN_VCORES =
    +		key("yarn.containers.vcores")
    +		.defaultValue(Integer.MAX_VALUE);
    --- End diff --
    
    Personally i think we should have methods that allow overriding the default for non-String
options; I've already opened FLINK-6638 for this.
    
    Let's use -1 as the default instead, it's a more "expected" invalid value i suppose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message