flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #4117: [FLINK-6813][table]Add TIMESTAMPDIFF supported in ...
Date Fri, 23 Jun 2017 10:15:22 GMT
Github user twalthr commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenUtils.scala
    @@ -289,4 +289,14 @@ object CodeGenUtils {
           case java.lang.Character.TYPE => s"$fieldTerm.setChar($objectTerm, $valueTerm)"
           case _ => s"$fieldTerm.set($objectTerm, $valueTerm)"
    +  def absFloorRound(value: Double): Long = {
    --- End diff --
    I would let this method return a string and add it to the `ScalarOperators`. The utils
class is actually intended for frequently used methods. Right now you are mixing code generation
and runtime methods.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message