flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhangminglei <...@git.apache.org>
Subject [GitHub] flink pull request #4168: [FLINK-6987] Fix erroneous when path containing sp...
Date Fri, 23 Jun 2017 13:08:24 GMT
Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4168#discussion_r123743180
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java
---
    @@ -461,8 +463,9 @@ public LocatableInputSplitAssigner getInputSplitAssigner(FileInputSplit[]
splits
     		
     		// take the desired number of splits into account
     		minNumSplits = Math.max(minNumSplits, this.numSplits);
    -		
    -		final Path path = this.filePath;
    +
    +		final Path path = new Path(URLDecoder.decode(this.filePath.toString(), Charset.defaultCharset().name()));
    --- End diff --
    
    We can also use ```parentDir.getAbsoluteFile().toString()``` to hack that. Not very sure
about which way is better. I would think ```parentDir.getAbsoluteFile().toString()``` is better
as it can obtain the whole path. What do you think ? @zentol 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message