flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #4191: [FLINK-6867] [elasticsearch] Fix instable Elastics...
Date Tue, 27 Jun 2017 14:09:51 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4191#discussion_r124284249
  
    --- Diff: flink-connectors/flink-connector-elasticsearch/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkITCase.java
---
    @@ -67,7 +68,11 @@ public void testTransportClientFails() throws Exception{
     
     	/**
     	 * Tests that the Elasticsearch sink works properly using an embedded node to connect
to Elasticsearch.
    +	 *
    +	 * NOTE: This is ignored, since executing both embedded client mode and transport client
mode introduces
    +	 * instability for node discovery in ES 1.x. See FLINK-6867.
     	 */
    +	@Ignore
    --- End diff --
    
    I would not expect it to be enabled again, at least for the Travis runs.
    At the rate of the new Elasticsearch versions (there's already a 6.x now), we might also
consider dropping 1.x support soon.
    
    Makes sense, will remove it completely :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message