flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...
Date Tue, 27 Jun 2017 14:12:00 GMT
Github user tzulitai commented on a diff in the pull request:

    --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
    @@ -119,6 +126,9 @@ public KafkaConsumerThread(
     		this.nextOffsetsToCommit = new AtomicReference<>();
     		this.running = true;
    +		this.successfulCommits = kafkaMetricGroup.counter("kafkaCommitsSucceeded");
    +		this.failedCommits = kafkaMetricGroup.counter("kafkaCommitsFailed");
    --- End diff --
    Please see my comment regarding the naming of the metrics.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message