flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #4195: [FLINK-7008] [cep] Update NFA state only when the ...
Date Tue, 27 Jun 2017 14:21:39 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4195#discussion_r124287999
  
    --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFATest.java
---
    @@ -324,6 +327,83 @@ public boolean filter(Event value) throws Exception {
     		}
     	}
     
    +	@Test
    +	public void testNFAChange() {
    +		Pattern<Event, ?> pattern = Pattern.<Event>begin("start").where(new SimpleCondition<Event>()
{
    +			private static final long serialVersionUID = 1858562682635302605L;
    +
    +			@Override
    +			public boolean filter(Event value) throws Exception {
    +				return value.getName().equals("a");
    +			}
    +		}).notFollowedBy("not").where(new IterativeCondition<Event>() {
    +			private static final long serialVersionUID = -6085237016591726715L;
    +
    +			@Override
    +			public boolean filter(Event value, Context<Event> ctx) throws Exception {
    +				return value.getName().equals("c");
    +			}
    +		}).followedByAny("middle").where(new IterativeCondition<Event>() {
    +			private static final long serialVersionUID = 8061969839441121955L;
    +
    +			@Override
    +			public boolean filter(Event value, Context<Event> ctx) throws Exception {
    +				return value.getName().equals("b");
    +			}
    +		}).oneOrMore().optional().allowCombinations().followedBy("middle2").where(new IterativeCondition<Event>()
{
    +			private static final long serialVersionUID = 8061969839441121955L;
    +
    +			@Override
    +			public boolean filter(Event value, Context<Event> ctx) throws Exception {
    +				return value.getName().equals("d");
    +			}
    +		}).followedBy("end").where(new IterativeCondition<Event>() {
    +			private static final long serialVersionUID = 8061969839441121955L;
    +
    +			@Override
    +			public boolean filter(Event value, Context<Event> ctx) throws Exception {
    +				return value.getName().equals("e");
    +			}
    +		}).within(Time.milliseconds(10));
    +
    +		NFACompiler.NFAFactory<Event> nfaFactory = NFACompiler.compileFactory(pattern,
Event.createTypeSerializer(), true);
    +		NFA<Event> nfa = nfaFactory.createNFA();
    +		nfa.process(new Event(1, "b", 1.0), 1L);
    +		assertFalse(nfa.isNFAChanged());
    +
    +		nfa.nfaChanged = false;
    --- End diff --
    
    Could you add comments for each assertion, what situation in NFA it covers?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message