flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #4170: [FLINK-6358] [gelly] Write job details for Gelly e...
Date Wed, 28 Jun 2017 14:15:31 GMT
Github user pnowojski commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
    @@ -305,6 +334,41 @@ public static void main(String[] args) throws Exception {
     				throw new ProgramParametrizationException("Unknown output type: " + outputName);
    +		// ----------------------------------------------------------------------------------------
    +		// Write job details
    --- End diff --
    It would nicer to extract this if condition to `writeJobDetails` method and delete this

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message