flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #4170: [FLINK-6358] [gelly] Write job details for Gelly e...
Date Wed, 28 Jun 2017 14:15:31 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4170#discussion_r124547387
  
    --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
    @@ -70,7 +79,8 @@
      * <p>Algorithms must explicitly support each type of output via implementation
of
      * interfaces. This is scalable as the number of outputs is small and finite.
      */
    -public class Runner {
    +public class Runner
    +extends ParameterizedBase {
    --- End diff --
    
    why do you extend `ParametrizedBase`? Isn't it intended as a base class for parameters?
Do you use `Runner` in such context?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message