flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #4146: [FLINK-6008][blob] collection of BlobServer improv...
Date Wed, 28 Jun 2017 15:20:32 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4146#discussion_r124566417
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
    @@ -509,21 +509,7 @@ private void delete(InputStream inputStream, OutputStream outputStream,
byte[] b
     
     			if (type == CONTENT_ADDRESSABLE) {
     				BlobKey key = BlobKey.readFromInputStream(inputStream);
    -				File blobFile = blobServer.getStorageLocation(key);
    -
    -				writeLock.lock();
    -
    -				try {
    -					// we should make the local and remote file deletion atomic, otherwise we might
risk not
    -					// removing the remote file in case of a concurrent put operation
    -					if (blobFile.exists() && !blobFile.delete()) {
    -						throw new IOException("Cannot delete BLOB file " + blobFile.getAbsolutePath());
    --- End diff --
    
    Don't you want to add a test coverage for not throwing if delete fails?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message