flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4146: [FLINK-6008][blob] collection of BlobServer improv...
Date Wed, 28 Jun 2017 16:06:04 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4146#discussion_r124584383
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
    @@ -593,9 +594,7 @@ private void sendPutHeader(OutputStream outputStream, JobID jobID,
String key) t
     	 *         the BLOB server or if the BLOB server cannot delete the file
     	 */
     	public void delete(BlobKey key) throws IOException {
    -		if (key == null) {
    -			throw new IllegalArgumentException("BLOB key must not be null");
    -		}
    +		checkArgument(key != null, "BLOB key must not be null.");
    --- End diff --
    
    unfortunately, `checkNotNull` throws a `NullPointerException` instead and I did not want
to change that here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message