flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink issue #4153: [FLINK-6927] [cep] Support pattern group in CEP
Date Thu, 29 Jun 2017 08:41:49 GMT
Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/4153
  
    @dianfu sorry I have not reviewed it yet, but I do think this feature would benefit from
reworking of the Pattern API I propose in [FLINK-3414](https://issues.apache.org/jira/browse/FLINK-3414).
    
    Instead of checking for head/tail of group pattern and caching them, we could more or
less use current code for plain sequence creation that could return begin/end states. Then
the code for joining groups would be much easier, cause it would operate on already translated
sequences.
    
    Also the new API would make [FLINK-4641]](https://issues.apache.org/jira/browse/FLINK-4641)
    much easier I think.
    
    As it would require API rework I would really like to hear @kl0u opinion. If we agree
though not to change the API I will go straight to reviewing this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message