flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6008) collection of BlobServer improvements
Date Wed, 28 Jun 2017 15:21:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066687#comment-16066687
] 

ASF GitHub Bot commented on FLINK-6008:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4146#discussion_r124568869
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobServerPutTest.java
---
    @@ -59,6 +60,110 @@
     
     	private final Random rnd = new Random();
     
    +
    +	// --- concurrency tests for utility methods which could fail during the put operation
---
    +
    +	/**
    +	 * Checked thread that calls {@link BlobServer#getStorageLocation(BlobKey)}
    +	 */
    +	public static class ContentAddressableGetStorageLocation extends CheckedThread {
    +		private final BlobServer server;
    +		private final BlobKey key;
    +
    +		public ContentAddressableGetStorageLocation(BlobServer server, BlobKey key) {
    +			this.server = server;
    +			this.key = key;
    +		}
    +
    +		@Override
    +		public void go() throws Exception {
    +			server.getStorageLocation(key);
    --- End diff --
    
    Shouldn't you call this at least couple/couple of dozens/couple of hundred times? Otherwise
won't this complete before next thread starts up?


> collection of BlobServer improvements
> -------------------------------------
>
>                 Key: FLINK-6008
>                 URL: https://issues.apache.org/jira/browse/FLINK-6008
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.3.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> The following things should be improved around the BlobServer/BlobCache:
> * update config uptions with non-deprecated ones, e.g. {{high-availability.cluster-id}}
and {{high-availability.storageDir}}
> * promote {{BlobStore#deleteAll(JobID)}} to the {{BlobService}}
> * extend the {{BlobService}} to work with {{NAME_ADDRESSABLE}} blobs (prepares FLINK-4399]
> * remove {{NAME_ADDRESSABLE}} blobs after job/task termination
> * do not fail the {{BlobServer}} when a delete operation fails
> * code style, like using {{Preconditions.checkArgument}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message