flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6008) collection of BlobServer improvements
Date Wed, 28 Jun 2017 15:21:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066688#comment-16066688
] 

ASF GitHub Bot commented on FLINK-6008:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4146#discussion_r124566819
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
    @@ -227,7 +227,7 @@ static File getStorageLocation(File storageDir, JobID jobID, String
key) {
     	private static File getJobDirectory(File storageDir, JobID jobID) {
     		final File jobDirectory = new File(storageDir, JOB_DIR_PREFIX + jobID.toString());
     
    -		if (!jobDirectory.exists() && !jobDirectory.mkdirs()) {
    --- End diff --
    
    Why did you change the order of those operations? Is that fix for something? If so could
you add explanation to the commit message what's going on here?


> collection of BlobServer improvements
> -------------------------------------
>
>                 Key: FLINK-6008
>                 URL: https://issues.apache.org/jira/browse/FLINK-6008
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.3.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> The following things should be improved around the BlobServer/BlobCache:
> * update config uptions with non-deprecated ones, e.g. {{high-availability.cluster-id}}
and {{high-availability.storageDir}}
> * promote {{BlobStore#deleteAll(JobID)}} to the {{BlobService}}
> * extend the {{BlobService}} to work with {{NAME_ADDRESSABLE}} blobs (prepares FLINK-4399]
> * remove {{NAME_ADDRESSABLE}} blobs after job/task termination
> * do not fail the {{BlobServer}} when a delete operation fails
> * code style, like using {{Preconditions.checkArgument}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message