flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6281) Create TableSink for JDBC
Date Wed, 07 Jun 2017 09:30:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040578#comment-16040578
] 

ASF GitHub Bot commented on FLINK-6281:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3712#discussion_r120575757
  
    --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSinkTest.java
---
    @@ -0,0 +1,79 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.io.jdbc;
    +
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.java.typeutils.RowTypeInfo;
    +import org.apache.flink.runtime.state.FunctionSnapshotContext;
    +import org.apache.flink.streaming.api.datastream.DataStream;
    +import org.apache.flink.types.Row;
    +
    +import org.junit.Test;
    +
    +import static org.junit.Assert.assertArrayEquals;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertNotSame;
    +import static org.mockito.Mockito.mock;
    +import static org.mockito.Mockito.verify;
    +
    +/**
    + * Test for JDBCTableSink.
    + */
    +public class JDBCTableSinkTest {
    +	private static final String[] FIELD_NAMES = new String[]{"foo"};
    +	private static final TypeInformation[] FIELD_TYPES = new TypeInformation[]{
    +		BasicTypeInfo.STRING_TYPE_INFO
    +	};
    +
    +	@Test
    +	public void testOutputSink() throws Exception {
    +		JDBCOutputFormat outputFormat = mock(JDBCOutputFormat.class);
    +		JDBCTableSink sink = new JDBCTableSink(outputFormat);
    +		@SuppressWarnings("unchecked")
    +		DataStream<Row> dataStream = (DataStream<Row>) mock(DataStream.class);
    +		sink.emitDataStream(dataStream);
    +		verify(dataStream).addSink(sink);
    +	}
    +
    +	@Test
    +	public void testFlush() throws Exception {
    +		JDBCOutputFormat outputFormat = mock(JDBCOutputFormat.class);
    +		JDBCTableSink sink = new JDBCTableSink(outputFormat);
    +		@SuppressWarnings("unchecked")
    +		DataStream<Row> dataStream = (DataStream<Row>) mock(DataStream.class);
    +		sink.emitDataStream(dataStream);
    +		sink.snapshotState(mock(FunctionSnapshotContext.class));
    +		verify(dataStream).addSink(sink);
    +		verify(outputFormat).flush();
    --- End diff --
    
    let's not use mocking for this test. Just create an actual format/sink, give N values
to the sink where N < batchSize, verify they haven't been written yet, call flush, verify
they were written.


> Create TableSink for JDBC
> -------------------------
>
>                 Key: FLINK-6281
>                 URL: https://issues.apache.org/jira/browse/FLINK-6281
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>
> It would be nice to integrate the table APIs with the JDBC connectors so that the rows
in the tables can be directly pushed into JDBC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message