flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6461) Deprecate web-related configuration defaults in ConfigConstants
Date Mon, 19 Jun 2017 13:31:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053989#comment-16053989
] 

ASF GitHub Bot commented on FLINK-6461:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3951#discussion_r122706584
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -173,7 +173,7 @@ class JobManager(
        * to run in the actor system of the associated job manager.
        */
       val webMonitorPort : Int = flinkConfiguration.getInteger(
    -    ConfigConstants.JOB_MANAGER_WEB_PORT_KEY, -1)
    +    JobManagerOptions.WEB_PORT.key(), -1)
    --- End diff --
    
    I thought about doing that, but decided against it to preserve existing behavior. If no
port is configured at all, with the current code, a random port will be used. Someone out
there may be relying on this (although they should just explicitly set it to 0)


> Deprecate web-related configuration defaults in ConfigConstants
> ---------------------------------------------------------------
>
>                 Key: FLINK-6461
>                 URL: https://issues.apache.org/jira/browse/FLINK-6461
>             Project: Flink
>          Issue Type: Improvement
>          Components: Webfrontend
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message