flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
Date Wed, 21 Jun 2017 08:14:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057147#comment-16057147
] 

ASF GitHub Bot commented on FLINK-6494:
---------------------------------------

Github user zjureel commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4075#discussion_r123180174
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
---
    @@ -52,7 +52,74 @@
     		key("yarn.per-job-cluster.include-user-jar")
     			.defaultValue("ORDER");
     
    +	/**
    +	 * The vcores exposed by YARN.
    +	 */
    +	public static final ConfigOption<Integer> YARN_VCORES =
    +		key("yarn.containers.vcores")
    +		.defaultValue(Integer.MAX_VALUE);
    --- End diff --
    
    I determine this default by test case, sorry :( 
    In fact I want to use `noDefaultValue()` here, but I find this method can be used for
`String` only, and there's no `getInteger(ConfigOption<Integer> option, int overrideDefault)`
in `Configuration`.
    
    I think it may be better to add `public ConfigOption<T> noDefaultValue()` in `ConfigOptions`
and add `public int getString(ConfigOption<Integer> configOption, int overrideDefault)`
in `Configuration` . What do you think? THX :)


> Migrate ResourceManager configuration options
> ---------------------------------------------
>
>                 Key: FLINK-6494
>                 URL: https://issues.apache.org/jira/browse/FLINK-6494
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, ResourceManager
>            Reporter: Chesnay Schepler
>            Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message