flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6665) Pass a ScheduledExecutorService to the RestartStrategy
Date Thu, 29 Jun 2017 07:43:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067929#comment-16067929
] 

ASF GitHub Bot commented on FLINK-6665:
---------------------------------------

GitHub user zjureel opened a pull request:

    https://github.com/apache/flink/pull/4220

    [FLINK-6665] Pass a ScheduledExecutorService to the RestartStrategy

    … avoid any sleeps.
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjureel/flink FLINK-6665

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4220
    
----
commit 8de578ed761d79969c6ceaf5f696dc926396f137
Author: zjureel <zjureel@gmail.com>
Date:   2017-06-29T07:10:34Z

    [FLINK-6665] schedule the restart call by ScheduledExecutorService to avoid any sleeps.

----


> Pass a ScheduledExecutorService to the RestartStrategy
> ------------------------------------------------------
>
>                 Key: FLINK-6665
>                 URL: https://issues.apache.org/jira/browse/FLINK-6665
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Stephan Ewen
>            Assignee: Fang Yong
>             Fix For: 1.4.0
>
>
> Currently, the {{RestartStrategy}} is called when the {{ExecutionGraph}} should be restarted.
> To facilitate delays before restarting, the strategy simply sleeps, blocking the thread
that runs the ExecutionGraph's recovery method.
> I suggest to pass {{ScheduledExecutorService}}) to the {{RestartStrategy}} and let it
schedule the restart call that way, avoiding any sleeps.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message