flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6725) make requiresOver as a contracted method in udagg
Date Thu, 01 Jun 2017 03:33:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032379#comment-16032379

ASF GitHub Bot commented on FLINK-6725:

Github user wuchong commented on the issue:

    Regarding to (3), I agree with Fabian. From a user's perspective, it is not easy to implement
a `getAccumulatorType()` or `getResultType()` contract function, as the signature and return
type is complicated.

> make requiresOver as a contracted method in udagg
> -------------------------------------------------
>                 Key: FLINK-6725
>                 URL: https://issues.apache.org/jira/browse/FLINK-6725
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
> I realized requiresOver is defined in the udagg interface when I wrote up the udagg doc.
I would like to put requiresOver as a contract method. This makes the entire udagg interface
consistently and clean.

This message was sent by Atlassian JIRA

View raw message