flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chesnay Schepler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6729) Activate strict checkstyle for flink-runtime
Date Thu, 01 Jun 2017 11:00:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032783#comment-16032783
] 

Chesnay Schepler commented on FLINK-6729:
-----------------------------------------

Checkstyle plugin with exclusions for all current modules added for 1.4 in 16115f96353557fa445f8ec8580501954c0e5a64.

> Activate strict checkstyle for flink-runtime
> --------------------------------------------
>
>                 Key: FLINK-6729
>                 URL: https://issues.apache.org/jira/browse/FLINK-6729
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>
> Long term issue for incrementally introducing the strict checkstyle to flink-runtime.
> As proposed in https://github.com/apache/flink/pull/4032 we will introduce the checkstyle
incrementally by package.
> The following is a list of all packages under {{org/apache/flink/runtime}} and their
respective checkstyle violations:
> {code}
> akka 25
> blob 140
> broadcast 94
> checkpoint 381
> client 83
> clusterframework 281
> concurrent 33
> deployment 27
> event 17
> execution 74
> executiongraph 881
> filecache 33
> fs 62
> heartbeat 30
> highavailability 94
> instance 370
> io 1592
> iterative 316
> jobgraph 283
> jobmanager 717
> jobmaster 84
> leaderelection 54
> leaderretrieval 11
> memory 249
> messages 135
> minicluster 53
> net 46
> operators 7953
> plugable 27
> process 1
> query 106
> registration 43
> resourcemanager 114
> rpc 127
> security 58
> state 463
> taskexecutor 153
> taskmanager 343
> testutils 204
> util 536
> {code}
> {{metrics}}, {history}} and {{webmonitor}} are excluded from this list, as I'm not aware
of any large-scale issue/feature branch for any of then.
> There are a number of low-hanging fruits in there for which we could apply the checkstyle
regardless of current efforts in there, like process, or leaderretrieval.
> I will reach out to committers that are active in the runtime components to see which
of these we could modify without causing to much problems.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message