flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6841) using TableSourceTable for both Stream and Batch OR remove useless import
Date Tue, 06 Jun 2017 14:29:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038981#comment-16038981
] 

ASF GitHub Bot commented on FLINK-6841:
---------------------------------------

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/4061
  
    I'm not sure about this change. A batch table source would be able to create a time attribute
if it implements `DefinedProctimeAttribute`, right?


> using TableSourceTable for both Stream and Batch OR remove useless import
> -------------------------------------------------------------------------
>
>                 Key: FLINK-6841
>                 URL: https://issues.apache.org/jira/browse/FLINK-6841
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> 1. {{StreamTableSourceTable}} exist useless import of {{TableException}}
> 2. {{StreamTableSourceTable}} only override {{getRowType}} of  {{FlinkTable}}, I think
we can override the method in {{TableSourceTable}}, If so we can using {{TableSourceTable}}
for both {{Stream}} and {{Batch}}.
> What do you think? [~fhueske] [~twalthr]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message