flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer
Date Wed, 07 Jun 2017 13:49:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040905#comment-16040905
] 

ASF GitHub Bot commented on FLINK-6859:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4085
  
    +1 to merge


> StateCleaningCountTrigger should not delete timer
> -------------------------------------------------
>
>                 Key: FLINK-6859
>                 URL: https://issues.apache.org/jira/browse/FLINK-6859
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: Fabian Hueske
>            Assignee: sunjincheng
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state should not
delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or not.
> What do you think [~sunjincheng121]?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message