flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6863) Fully separate streaming&batch examples
Date Mon, 19 Jun 2017 11:18:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053815#comment-16053815

ASF GitHub Bot commented on FLINK-6863:

Github user zentol commented on the issue:

    Do we really need the note? I don't think anyone would now add a dependency to the batch
examples just to deduplicate the `WordCountData`. It would probably be ineffective as a deterrent
as there are plenty of opportunities for deduplication between the batch and streaming examples.

> Fully separate streaming&batch examples
> ---------------------------------------
>                 Key: FLINK-6863
>                 URL: https://issues.apache.org/jira/browse/FLINK-6863
>             Project: Flink
>          Issue Type: Improvement
>          Components: Examples
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
> The streaming examples module currently depends on the batch examples, specifically they
re-use {{WordCountData}} for {{PojoExample}}, {{SideOutputExample}}, {{WordCount}} and {{WindowWordCount}}.
> I propose simply copying the example data to make the module more self-contained.

This message was sent by Atlassian JIRA

View raw message