flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6898) Limit size of operator component in metric name
Date Mon, 19 Jun 2017 12:30:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053901#comment-16053901
] 

ASF GitHub Bot commented on FLINK-6898:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4109
  
    no, it's not safe nor does it actually fulfill the purpose. I better add a test for this....
    
    We can't just fail, as the metric system shouldn't throw exceptions, since this isn't
a problem that affects job execution.
    
    I've moved the truncation into `TaskMetricGroup#addOperator()` which is the only call
to the constructor outside of tests (as intended).


> Limit size of operator component in metric name
> -----------------------------------------------
>
>                 Key: FLINK-6898
>                 URL: https://issues.apache.org/jira/browse/FLINK-6898
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Critical
>             Fix For: 1.3.1, 1.4.0
>
>
> The operator name for some operators (specifically windows) can be very, very long (250+)
characters.
> I propose to limit the total space that the operator component can take up in a metric
name to 60 characters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message