flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chesnay Schepler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6907) Remove TupleGenerator in flink-java
Date Wed, 21 Jun 2017 12:20:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057391#comment-16057391
] 

Chesnay Schepler commented on FLINK-6907:
-----------------------------------------

yes, it appears that they are both needed.

The one in flink-core creates a Tuple classes, along with the builders.
{code}
createTupleClasses(root);
createTupleBuilderClasses(root);
modifyTupleType(root);
{code}
The one in flink-java modifies the CsvReader / Join-/Cross-/ProjectOperator classes.
{code}
modifyCsvReader(root);
modifyProjectOperator(root);
modifyJoinProjectOperator(root);
modifyCrossProjectOperator(root);
{code}

I'll adjust the class javadocs to make that a bit more obvious.

> Remove TupleGenerator in flink-java
> -----------------------------------
>
>                 Key: FLINK-6907
>                 URL: https://issues.apache.org/jira/browse/FLINK-6907
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.4.0
>
>
> I just found a {{TupleGenerator}} class in the test files of {{flink-java}}, which appears
to be unused. It also looks very similar to the one in {{flink-core}}.
> Does anyone know why it exists?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message