flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6938) IterativeCondition should support RichFunction interface
Date Tue, 20 Jun 2017 14:20:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055834#comment-16055834
] 

ASF GitHub Bot commented on FLINK-6938:
---------------------------------------

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4145#discussion_r122982790
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java
---
    @@ -68,6 +72,15 @@ public StateTransitionAction getAction() {
     		return sourceState;
     	}
     
    +	public IterativeCondition<T> getCondition(ConditionRegistry conditionRegistry)
{
    +		return conditionRegistry.getCondition(this);
    +	}
    +
    +	/**
    +	 * @deprecated 	This field remains for backwards compatibility.
    +	 * Now the condition getter should use {@link #getCondition(ConditionRegistry)}.
    +	 */
    +	@Deprecated
     	public IterativeCondition<T> getCondition() {
    --- End diff --
    
    I also think we could get rid of it.


> IterativeCondition should support RichFunction interface
> --------------------------------------------------------
>
>                 Key: FLINK-6938
>                 URL: https://issues.apache.org/jira/browse/FLINK-6938
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>             Fix For: 1.4.0
>
>
> In FLIP-20, we need IterativeCondition to support an {{open()}} method to compile the
generated code once. We do not want to insert a if condition  in the {{filter()}} method.
So I suggest make IterativeCondition support {{RichFunction}} interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message