flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6938) IterativeCondition should support RichFunction interface
Date Tue, 20 Jun 2017 14:20:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055835#comment-16055835
] 

ASF GitHub Bot commented on FLINK-6938:
---------------------------------------

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4145#discussion_r122982179
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java
---
    @@ -36,6 +36,12 @@
     	private final StateTransitionAction action;
     	private final State<T> sourceState;
     	private final State<T> targetState;
    +
    +	/**
    +	 * @deprecated 	This field remains for backwards compatibility.
    +	 * Now the condition is stored in {@link ConditionRegistry}.
    +	 */
    +	@Deprecated
     	private IterativeCondition<T> newCondition;
    --- End diff --
    
    Fields introduced prior to 1.3.0 needed to be `@deprecated` because java serialization
was used for serializing NFA. Since 1.3.0 a custom serialization is used and this field was
introduced for 1.3.0 so I think we can get rid of it completely. Am I right?


> IterativeCondition should support RichFunction interface
> --------------------------------------------------------
>
>                 Key: FLINK-6938
>                 URL: https://issues.apache.org/jira/browse/FLINK-6938
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>             Fix For: 1.4.0
>
>
> In FLIP-20, we need IterativeCondition to support an {{open()}} method to compile the
generated code once. We do not want to insert a if condition  in the {{filter()}} method.
So I suggest make IterativeCondition support {{RichFunction}} interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message