flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6948) EnumValueSerializer cannot handle removed enum values
Date Mon, 19 Jun 2017 12:13:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053882#comment-16053882
] 

ASF GitHub Bot commented on FLINK-6948:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4142#discussion_r122682551
  
    --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/EnumValueSerializer.scala
---
    @@ -150,8 +162,29 @@ object EnumValueSerializer {
                 enumClass = InstantiationUtil.deserializeObject(
                   inViewWrapper, getUserCodeClassLoader)
    --- End diff --
    
    Since we're changing the serialization format, we might as well also exclude Java serialization
here for good now. Otherwise we'll need to bump the version again afterwards.


> EnumValueSerializer cannot handle removed enum values
> -----------------------------------------------------
>
>                 Key: FLINK-6948
>                 URL: https://issues.apache.org/jira/browse/FLINK-6948
>             Project: Flink
>          Issue Type: Bug
>          Components: Type Serialization System
>    Affects Versions: 1.3.1, 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Critical
>
> The {{EnumValueSerializer}} cannot handle removed enum values or enum values whose ordinal
value have been changed. We should try to detect these cases and require migration. The problem
is that we take the values of the new enum and iterate over them without checking that all
old enum values contained in the config snapshot are actually contained.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message