flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback
Date Tue, 27 Jun 2017 14:12:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064901#comment-16064901
] 

ASF GitHub Bot commented on FLINK-6998:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4187#discussion_r124284709
  
    --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
    @@ -119,6 +126,9 @@ public KafkaConsumerThread(
     
     		this.nextOffsetsToCommit = new AtomicReference<>();
     		this.running = true;
    +
    +		this.successfulCommits = kafkaMetricGroup.counter("kafkaCommitsSucceeded");
    +		this.failedCommits = kafkaMetricGroup.counter("kafkaCommitsFailed");
    --- End diff --
    
    Please see my comment regarding the naming of the metrics.


> Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka
Consumer callback
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-6998
>                 URL: https://issues.apache.org/jira/browse/FLINK-6998
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Zhenzhong Xu
>            Assignee: Zhenzhong Xu
>
> Propose to add "kafkaCommitsSucceeded" and "kafkaCommitsFailed" metrics in KafkaConsumerThread
class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message