flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7000) Add custom configuration for StreamExecutionEnvironment#createLocalEnvironment
Date Sat, 24 Jun 2017 14:45:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062016#comment-16062016
] 

ASF GitHub Bot commented on FLINK-7000:
---------------------------------------

GitHub user ch33hau opened a pull request:

    https://github.com/apache/flink/pull/4178

    [FLINK-7000] Add custom configuration local environment in Scala StreamExecutionEnvironment

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ch33hau/flink custom-configuration-for-scala-stream-env

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4178
    
----
commit 03059ede52f2b28b70a1f8f2161348368bc95225
Author: Lim Chee Hau <ch33hau@gmail.com>
Date:   2017-06-24T14:26:15Z

    [FLINK-7000] Add custom configuration local environment in Scala StreamExecutionEnvironment

----


> Add custom configuration for StreamExecutionEnvironment#createLocalEnvironment
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-7000
>                 URL: https://issues.apache.org/jira/browse/FLINK-7000
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Lim Chee Hau
>
> I was doing some local testings in {{Scala}} environment, however I found that there
is no straightforward way to add custom configuration to {{StreamExecutionEnvironment}} by
using {{createLocalEnvironment}} method. 
> This could be easily achieve in {{Java}} environment since {{StreamExecutionEnvironment}}
in {{Java}} has 
> - createLocalEnvironment()
> - createLocalEnvironment(Int)
> - createLocalEnvironment(Int, Configuration)
> Whereas Scala only has 2 out of 3 of these methods.
> Not sure if this is a missing implementation, if yes I could create a PR for this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message