flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7008) Update NFA state only when the NFA changes.
Date Tue, 27 Jun 2017 12:42:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064769#comment-16064769
] 

ASF GitHub Bot commented on FLINK-7008:
---------------------------------------

GitHub user dianfu opened a pull request:

    https://github.com/apache/flink/pull/4195

    [FLINK-7008] [cep] Update NFA state only when the NFA changes

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dianfu/flink FLINK-7008

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4195
    
----
commit 36b9baaaffecf8be32b5e8bb5887ccbd43430caf
Author: Dian Fu <fudian.fd@alibaba-inc.com>
Date:   2017-06-27T12:38:53Z

    [FLINK-7008] [cep] Update NFA state only when the NFA changes

----


> Update NFA state only when the NFA changes.
> -------------------------------------------
>
>                 Key: FLINK-7008
>                 URL: https://issues.apache.org/jira/browse/FLINK-7008
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.3.1
>            Reporter: Kostas Kloudas
>             Fix For: 1.4.0
>
>
> Currently in the {{AbstractKeyedCEPPatternOperator.updateNFA()}} method we update the
NFA state every time the NFA is touched. This leads to redundant puts/gets to the state when
there are no changes to the NFA itself.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message