flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4126: [FLINK-6921] [serializer] Allow EnumValueSerialize...
Date Wed, 14 Jun 2017 15:48:20 GMT
GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4126

    [FLINK-6921] [serializer] Allow EnumValueSerializer to deal with appended enum values

    The problem was that we don't check the bounds of the array with the enum names contained
    in the ScalaEnumSerializerConfigSnapshot.
    
    This PR also adds an Enumeration upgrade test which makes sure that appended fields are
    supported without migration. Moreover, it checks that a field removal and an order change
    leads to a required migration.
    
    cc @tzulitai 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink addEnumValueSerializerTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4126
    
----
commit 0f2dcbab59185888137f2d0b278878f3d83c7aa2
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-06-14T14:53:49Z

    [FLINK-6921] [serializer] Allow EnumValueSerializer to deal with appended enum values
    
    The problem was that we don't check the bounds of the array with the enum names contained
    in the ScalaEnumSerializerConfigSnapshot.
    
    This PR also adds an Enumeration upgrade test which makes sure that appended fields are
    supported without migration. Moreover, it checks that a field removal and an order change
    leads to a required migration.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message