flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4139: [FLINK-6945] Fix TaskCancelAsyncProducerConsumerIT...
Date Mon, 19 Jun 2017 07:58:24 GMT
GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4139

    [FLINK-6945] Fix TaskCancelAsyncProducerConsumerITCase by removing race condition

    The TaskCacnelAsyncProducerConsumerITCase#testCancelAsyncProducerAndConsumer test case
    sometimes failed with a NPE because of a race condition. The problem was that some
    invokables set static fields which are checked in the main thread. Since we checked
    the wrong field, the one for the consumer, after making sure that the producer
    is running, this could lead to a race condition if the consumer wasn't running yet.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixTaskCancelAsyncProducerConsumerITCase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4139
    
----
commit a1356b951326d7f40a05eb61034a46b941d18faa
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-06-19T07:54:35Z

    [FLINK-6945] Fix TaskCancelAsyncProducerConsumerITCase by removing race condition
    
    The TaskCacnelAsyncProducerConsumerITCase#testCancelAsyncProducerAndConsumer test case
    sometimes failed with a NPE because of a race condition. The problem was that some
    invokables set static fields which are checked in the main thread. Since we checked
    the wrong field, the one for the consumer, after making sure that the producer
    is running, this could lead to a race condition if the consumer wasn't running yet.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message