flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...
Date Fri, 03 Nov 2017 15:27:28 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4729#discussion_r148809690
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -260,6 +287,7 @@ public void onContainersAllocated(List<Container> containers)
{
     			numPendingContainerRequests = Math.max(0, numPendingContainerRequests - 1);
     			log.info("Received new container: {} - Remaining pending container requests: {}",
     					container.getId(), numPendingContainerRequests);
    +			workerNodeMap.put(container.getId().toString(), new YarnWorkerNode(container));
    --- End diff --
    
    Here we should create a `ResourceID` to use it as the key. This `ResourceID` must then
be send to the launched TaskManager such that it uses it upon registration.


---

Mime
View raw message