flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...
Date Fri, 03 Nov 2017 15:27:48 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4729#discussion_r148807573
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -63,11 +64,14 @@
      * The yarn implementation of the resource manager. Used when the system is started
      * via the resource framework YARN.
      */
    -public class YarnResourceManager extends ResourceManager<ResourceID> implements
AMRMClientAsync.CallbackHandler {
    +public class YarnResourceManager extends ResourceManager<YarnWorkerNode> implements
AMRMClientAsync.CallbackHandler {
     
     	/** The process environment variables. */
     	private final Map<String, String> env;
     
    +	/** YARN container map. Package private for unit test purposes. */
    +	final Map<String, YarnWorkerNode> workerNodeMap;
    --- End diff --
    
    Let's make it more visible that this map is a concurrent map by setting the type to `CocnurrentHashMap`.


---

Mime
View raw message