flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #4981: [FLINK-7419][build][avro] Relocate jackson in flin...
Date Thu, 09 Nov 2017 16:50:27 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4981#discussion_r150020494
  
    --- Diff: flink-formats/flink-avro/pom.xml ---
    @@ -185,17 +185,6 @@ under the License.
     						<configuration combine.self="override">
     							<dependencyReducedPomLocation>${project.basedir}/target/dependency-reduced-pom.xml</dependencyReducedPomLocation>
     							<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
    --- End diff --
    
    We can probably remove the complete shading entry in that pom. Seem not to do anything
anyways. Promoting transitive dependencies when nothing except `force-shading` is shaded into
the jar should be a no-op. (theoretically, one never knows with the shade plugin ;-) )


---

Mime
View raw message