flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...
Date Tue, 21 Nov 2017 14:49:50 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4509#discussion_r152255421
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
    @@ -394,7 +419,63 @@ public BufferProvider getBufferProvider() throws IOException {
     		return inputGate.getBufferProvider();
     	}
     
    -	public void onBuffer(Buffer buffer, int sequenceNumber) {
    +	/**
    +	 * Requests buffer from input channel directly for receiving network data.
    +	 * It should always return an available buffer in credit-based mode unless
    +	 * the channel has been released.
    +	 *
    +	 * @return The available buffer.
    +	 */
    +	@Nullable
    +	public Buffer requestBuffer() {
    +		synchronized (bufferQueue) {
    +			// Take the floating buffer first if possible.
    +			if (bufferQueue.getFloatingBufferSize() > 0) {
    --- End diff --
    
    Also extract this into a more generic `bufferQueue.takeBuffer()` and move the logic (exclusive
vs. floating buffers) there?


---

Mime
View raw message