flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...
Date Tue, 21 Nov 2017 14:49:50 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4509#discussion_r152245491
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
    @@ -240,15 +245,13 @@ void releaseAllResources() throws IOException {
     					}
     				}
     			}
    -
    -			synchronized (availableBuffers) {
    +			synchronized (bufferQueue) {
    --- End diff --
    
    add a `AvailableBufferQueue#releaseAll(exclusiveRecyclingSegments)`?


---

Mime
View raw message