flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...
Date Tue, 21 Nov 2017 14:49:50 GMT
Github user NicoK commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
    @@ -134,9 +138,9 @@ void assignExclusiveSegments(List<MemorySegment> segments) {
    --- End diff --
    How about adding (most of) this method's body into the `AvailableBufferQueue` class, including
some more data handling logic? This way, we can separate the network handling a bit from the
buffer logic. (I'll add comments to some more things to extract below)
    Also, you could test the buffer logic alone (inside `AvailableBufferQueue`) a bit better.


View raw message