flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5038: [FLINK-7880][FLINK-7975][FLINK-7974][QS] QS test i...
Date Tue, 21 Nov 2017 15:04:16 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5038#discussion_r152298612
  
    --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
    @@ -386,6 +430,9 @@ private PendingRequest(REQ request) {
     		/** Reference to a failure that was reported by the channel. */
     		private final AtomicReference<Throwable> failureCause = new AtomicReference<>();
     
    +		/** Atomic shut down future. */
    +		private final AtomicReference<CompletableFuture<Boolean>> connectionShutdownFuture
= new AtomicReference<>(null);
    --- End diff --
    
    why does this one suddenly return a boolean?


---

Mime
View raw message