flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #4471: [FLINK-6094] [table] Implement stream-stream proct...
Date Thu, 23 Nov 2017 16:01:58 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4471#discussion_r152812041
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/table/validation/JoinValidationTest.scala
---
    @@ -92,4 +92,85 @@ class JoinValidationTest extends TableTestBase {
     
         util.verifyTable(resultTable, "")
       }
    +
    +
    +  private val util = streamTestUtil()
    +  private val ds1 = util.addTable[(Int, Long, String)]("Table3",'a, 'b, 'c)
    +  private val ds2 = util.addTable[(Int, Long, Int, String, Long)]("Table5", 'd, 'e, 'f,
'g, 'h)
    +
    +  @Test(expected = classOf[ValidationException])
    +  def testJoinNonExistingKey(): Unit = {
    +    ds1.join(ds2)
    +      // must fail. Field 'foo does not exist
    +      .where('foo === 'e)
    +      .select('c, 'g)
    +  }
    +
    +  @Test(expected = classOf[ValidationException])
    +  def testJoinWithNonMatchingKeyTypes(): Unit = {
    +    ds1.join(ds2)
    +      // must fail. Field 'a is Int, and 'g is String
    +      .where('a === 'g)
    +      .select('c, 'g)
    +  }
    +
    +
    --- End diff --
    
    Remove empty line.


---

Mime
View raw message