flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...
Date Thu, 23 Nov 2017 16:18:51 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4581#discussion_r152822778
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java
---
    @@ -95,20 +95,23 @@ public boolean add(Buffer buffer) throws IOException {
     				return false;
     			}
     
    -			// The number of buffers are needed later when creating
    -			// the read views. If you ever remove this line here,
    -			// make sure to still count the number of buffers.
    -			updateStatistics(buffer);
    -
     			if (spillWriter == null) {
     				buffers.add(buffer);
    +				// The number of buffers are needed later when creating
    +				// the read views. If you ever remove this line here,
    +				// make sure to still count the number of buffers.
    --- End diff --
    
    Is it tested somewhere? 


---

Mime
View raw message