flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...
Date Thu, 23 Nov 2017 17:02:11 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4581#discussion_r152847273
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
    @@ -300,6 +315,230 @@ public void testConsumeSpillablePartitionSpilledDuringConsume()
throws Exception
     		assertTrue(buffer.isRecycled());
     	}
     
    +	/**
    --- End diff --
    
    you're right - some tests actually share most of their code. I'll extract a common test
method to reduce some code.


---

Mime
View raw message